Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace alias with address in copy for consistency #4402

Merged
merged 1 commit into from
May 26, 2020
Merged

Replace alias with address in copy for consistency #4402

merged 1 commit into from
May 26, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 14, 2020

@t3chguy
s/alias/address/ in copy
384336e 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested review from a team April 14, 2020 09:09
bwindels
bwindels approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this!

@t3chguy
Copy link
Member Author

t3chguy commented Apr 14, 2020

Parking this as M is unhappy with Addresses generally: https://matrix.to/#/!maVEfftuKxhnPMcckU:matrix.org/$1586855783869884UPeMe:matrix.org?via=matrix.org&via=riot.ovh&via=t2l.io

@t3chguy t3chguy removed the blocked label May 24, 2020
@t3chguy
Copy link
Member Author

t3chguy commented May 24, 2020

M is happy with it once again, pending Design review

nadonomy
nadonomy approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t3chguy t3chguy merged commit 707e22a into develop May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Room alias vs address, inconsistent terminology
3 participants
@t3chguy @bwindels @nadonomy